-
Notifications
You must be signed in to change notification settings - Fork 33
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Solution? #23
base: main
Are you sure you want to change the base?
Solution? #23
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good, but fix EoF
apiVersion: v1 | ||
kind: Namespace | ||
metadata: | ||
name: {{ .Values.mysql.namespace }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
data: | ||
{{- range $k, $v := .Values.mysql.secrets }} | ||
{{ $k }}: {{ $v | b64enc}} | ||
{{- end }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
# pod-name.service-name.namespace.svc.cluster.local | ||
# pod-name.service-name | ||
# mysql-0.mysql.mysql.svc.cluster.local |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You don't need to leave these comments in the PR
name: {{ .Chart.Name }}-config | ||
namespace: {{ .Values.todoapp.namespace }} | ||
data: | ||
PYTHONUNBUFFERED: "1" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
- key: app | ||
operator: In | ||
values: | ||
- kube2py |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
service: | ||
name: {{ .Chart.Name }}-service | ||
port: | ||
number: {{ .Values.todoapp.service.port }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
apiVersion: v1 | ||
kind: Namespace | ||
metadata: | ||
name: {{ .Values.todoapp.namespace }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
- ReadWriteMany | ||
resources: | ||
requests: | ||
storage: {{ .Values.todoapp.volumes.persistentVolumeClaim.requestStorage }} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
roleRef: | ||
kind: Role | ||
name: secrets-reader | ||
apiGroup: rbac.authorization.k8s.io |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Add Eof(End-of-file), need to add blank line at the end
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good job!
No description provided.